Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel execution - minor changes #5

Merged
merged 25 commits into from
May 7, 2024

Conversation

keradus
Copy link

@keradus keradus commented May 5, 2024

@coveralls
Copy link

coveralls commented May 6, 2024

Pull Request Test Coverage Report for Build 8992649239

Details

  • 39 of 40 (97.5%) changed or added relevant lines in 6 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.003%) to 95.696%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Console/Command/WorkerCommand.php 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
src/Runner/Runner.php 1 63.87%
src/Cache/FileCacheManager.php 4 84.62%
Totals Coverage Status
Change from base Build 8975812999: -0.003%
Covered Lines: 27324
Relevant Lines: 28553

💛 - Coveralls

Copy link
Owner

@Wirone Wirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things that I am not fully comfortable with, let's discuss 🙂.

src/Runner/Parallel/ProcessPool.php Outdated Show resolved Hide resolved
src/Runner/Runner.php Outdated Show resolved Hide resolved
src/ParallelAwareConfigInterface.php Show resolved Hide resolved
src/Runner/Parallel/ParallelConfigFactory.php Show resolved Hide resolved
src/Error/ErrorsManager.php Outdated Show resolved Hide resolved
src/Runner/Runner.php Outdated Show resolved Hide resolved
@Wirone
Copy link
Owner

Wirone commented May 7, 2024

I have reverted 2 commits that I don't agree on, so I can push other things forward and merge @keradus' PRs. We can align on those 2 things separately.

@Wirone Wirone merged commit 762c5da into Wirone:codito/bombazo May 7, 2024
26 checks passed
@Wirone
Copy link
Owner

Wirone commented May 7, 2024

Thanks @keradus 🍻!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants