Revert "minor: ErrorsManager - no need for forPath, but we need getAl…

…l instead"

This reverts commit 891df50.

src/Console/Command/WorkerCommand.php

@@ -166,7 +166,7 @@ function (ConnectionInterface $connection) use ($loop, $runner, $identifier): vo
                                 // @phpstan-ignore-next-line False-positive caused by assigning empty array to $events property
                                 'status' => isset($this->events[0]) ? $this->events[0]->getStatus() : null,
                                 'fixInfo' => $analysisResult[$relativePath] ?? null,
-                                'errors' => $this->errorsManager->popAllErrors(),
+                                'errors' => $this->errorsManager->forPath($absolutePath),
                             ]);
                         }
 

src/Error/ErrorsManager.php

@@ -74,14 +74,13 @@ public function getLintErrors(): array
     }
 
     /**
+     * Returns errors reported for specified path.
+     *
      * @return list<Error>
      */
-    public function popAllErrors(): array
+    public function forPath(string $path): array
     {
-        $errors = $this->errors;
-        $this->errors = [];
-
-        return $errors;
+        return array_values(array_filter($this->errors, static fn (Error $error): bool => $path === $error->getFilePath()));
     }
 
     /**

tests/Error/ErrorsManagerTest.php

@@ -140,10 +140,8 @@ public function testThatCanReportAndRetrieveErrorsForSpecificPath(): void
 
         self::assertFalse($errorsManager->isEmpty());
 
-        $errors = $errorsManager->popAllErrors();
-        self::assertCount(5, $errors);
+        $errors = $errorsManager->forPath('foo.php');
 
-        $errors = $errorsManager->popAllErrors();
-        self::assertCount(0, $errors);
+        self::assertCount(3, $errors);
     }
 }