Number of jobs should not be set in Makefile #64
Conversation
j16 is an awful lot of jobs and usually results in termination of the compiler. The number of jobs used by make can be set using the command line argument -jN to make, where N is the number of jobs
|
cc: @rouben |
|
The issue with this PR is that it will be difficult to maintain once a new release is available upstream. Remember, this repo is based on the contents of 7Zip/ZIP archives released upstream by the original author, who maintains their own private SubVersion repo for development. Any ideas on how we can prevent this change from getting squashed with future releases? |
|
Manually merging the Makefile, maybe? |
|
@rouben I think, since the software hasn't been updated since 2020, it's probably better to make a tag for the current HEAD and then apply some fixes so that if a new version is released on the MDL website then the repo can be updated easily by making a branch at the original head, i.e. the tag. |
The value of N in -jN depends on many factors and the decision should be ultimately left up to the user