Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify validation of needed option due to fact that kerberos authenti… #326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

modify validation of needed option due to fact that kerberos authenti… #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/winrm/connection_opts.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ def validate_required_fields
if self[:client_cert]
raise 'path to client key is required' unless self[:client_key]
else
raise 'user is a required option' unless self[:user]
raise 'password is a required option' unless self[:password]
raise 'user is a required option' unless self[:transport] == :kerberos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this change: if user and password but not kerberos is provided, this will raise, won't it? that seems incorrect.

raise 'password is a required option' unless self[:transport] == :kerberos
end
end

Expand Down