-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legacy4J 1.7.1 - Minecraft 1.19.4 Port (Deprecated Version) #577
base: 1.20.1
Are you sure you want to change the base?
Conversation
I'm glad I made this a Draft because seems like I gotta adjust it and make it better. |
This is a legacy version of CommonInputs. Made for 1.19.x and lower. This is necessary to fix errors and to resolve the lack of CommonInputs.
rebranded Pull Request to target Legacy4J 1.7.3 instead of Legacy4J 1.7.1 |
rip, I got to reverse all the changes in this pull request and fix the conflicts shown. |
Not finished code. this commit was made just so I could have the ability to compare the changes easily for Legacy4J v1.7.3.
I just recently known about the server being archived and it was sad I had missed out. Because I had a final message planned for the thread. I think the issues channel on the server can see this so here’s my response to the Default Dark Mode: Expansion resource pack below. • Default Dark Mode: Expansion - L4J Dark Mode Compatibility: The resource pack will continue to work with Legacy4J even after being archived. And when Legacy4J does return I’ll still continue to provide dark mode support to it. • About the 1.19.4 port of Legacy4J: this hasn’t been achievable because I thought it would be an easy process to port it down to at least 1.19.4, and was afraid to say that I am not a very good Minecraft coder. But eventually I could accomplish it if I keep trying. when I do so I will probably undraft this. |
Warning
Do not merge this to the branch, the reason is that this Pull Request is targeting 1.20.1 branch which isn’t the one that I wanted it pushed at, I recommend merging and pushing this pull request to a new branch called 1.19.4
Pull Request
This is a Pull Request to introduce Legacy4J in 1.19.4, this was because 1.19 is still one of the popular versions being played like 1.18, 1.20 & 1.21. I had the idea to backport Legacy4J 1.20.1 code to 1.19.4 and this old version doesn’t have the following content which is ContentValidationException, CommonInputs, FaviconTexture, ForbiddenSymlinkInfo,
GuiGraphics, SymlinkWarningScreen & possibly more.
Errors
This one might be odd but I failed to fix the last 2 remaining errors related to a mixin called GuiGraphicsMixin.java
and since this can be a problem I decided to make this Pull Request a Draft for now.