Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

884: Letting admin to delete keyword #960

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

Veda-Gogineni
Copy link
Contributor

Pull Request Overview

  • This PR is to address: admin - delete a keyword #884
  • The proposed code change involves two schema updates. It enables cascade delete on two tables (annotation_keywords, asset_tags).

@Veda-Gogineni Veda-Gogineni changed the title Letting admin to delete keyword 884: Letting admin to delete keyword Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e65b96) 73.5% compared to head (b7b1dd7) 73.5%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #960   +/-   ##
=====================================
  Coverage   73.5%   73.5%           
=====================================
  Files        242     242           
  Lines      23873   23873           
  Branches    4347    4347           
=====================================
  Hits       17561   17561           
  Misses      5026    5026           
  Partials    1286    1286           
Files Coverage Δ
app/modules/annotations/models.py 79.8% <100.0%> (ø)
app/modules/assets/models.py 80.0% <100.0%> (ø)
app/modules/users/permissions/rules.py 83.6% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e65b96...b7b1dd7. Read the comment docs.

Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@naknomum naknomum merged commit 813a459 into WildMeOrg:main Jan 23, 2024
9 of 10 checks passed
@TanyaStere42 TanyaStere42 linked an issue Jan 29, 2024 that may be closed by this pull request
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

admin - delete a keyword
2 participants