Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

875: ensure that site.species site-settings does not remove in-use taxonomy #926

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

naknomum
Copy link
Member

#875 fix site-setting api to disallow updating site.species to remove an in-use Taxonomy

@naknomum naknomum self-assigned this Oct 24, 2023
@naknomum naknomum linked an issue Oct 24, 2023 that may be closed by this pull request
@naknomum naknomum force-pushed the 875_species_usage_fix branch from 439ec2e to adebb1a Compare October 24, 2023 23:06
@naknomum naknomum marked this pull request as ready for review October 24, 2023 23:07
@naknomum naknomum requested a review from erinz2020 October 24, 2023 23:09
Copy link
Contributor

@erinz2020 erinz2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #926 (adebb1a) into main (a73f87e) will decrease coverage by 0.1%.
The diff coverage is 83.3%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #926     +/-   ##
=======================================
- Coverage   73.3%   73.3%   -0.1%     
=======================================
  Files        238     238             
  Lines      23373   23395     +22     
  Branches    4223    4232      +9     
=======================================
+ Hits       17154   17159      +5     
- Misses      4970    4981     +11     
- Partials    1249    1255      +6     
Files Coverage Δ
app/modules/site_settings/helpers.py 79.5% <83.3%> (+<0.1%) ⬆️
app/modules/site_settings/models.py 77.5% <83.3%> (+0.1%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a73f87e...adebb1a. Read the comment docs.

@naknomum naknomum merged commit cb05676 into main Oct 25, 2023
10 of 11 checks passed
@naknomum naknomum deleted the 875_species_usage_fix branch October 25, 2023 00:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

species can be removed even when in use
2 participants