Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search result changes to allow inaccessible results #959

Merged
merged 7 commits into from
Dec 21, 2024

Conversation

naknomum
Copy link
Member

@naknomum naknomum commented Dec 20, 2024

search results allow user to see minimal results for matches they do not have access to

PR fixes #958

  • Do not limit query based on permissions
  • API:
    • Return all results, with inaccessible ones containing only minimal fields
    • New field access can be used to stylize/filter results based on user permissions
  • EncounterQueryProcessor: only allow items with access (skip inaccessible)

@naknomum naknomum marked this pull request as ready for review December 20, 2024 22:40
@naknomum naknomum requested a review from holmbergius December 20, 2024 22:43
Copy link
Contributor

@holmbergius holmbergius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@holmbergius holmbergius merged commit f208f0d into main Dec 21, 2024
1 check passed
@holmbergius holmbergius deleted the 958_search_result_changes branch December 21, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

encounter search display all, restrict access
3 participants