Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

915 configurable encounter search #943

Merged
merged 7 commits into from
Dec 16, 2024
Merged

915 configurable encounter search #943

merged 7 commits into from
Dec 16, 2024

Conversation

erinz2020
Copy link
Contributor

@erinz2020 erinz2020 commented Dec 13, 2024 •
edited
Loading

  1. update commonConguration.properties to add a toggle to show/hide encounterSearch.jsp
  2. reflect this in jsp, react and servlet template headers
  3. new menu option is Encounter Search (Classic)

PR fixes #915

@erinz2020 erinz2020 self-assigned this Dec 13, 2024
TanyaStere42
TanyaStere42 requested changes Dec 13, 2024
View reviewed changes
Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is missing the changes for the servletResponseTemplate.htm?

src/main/resources/bundles/commonConfiguration.properties Show resolved Hide resolved
naknomum
naknomum approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the typo, i am signing off on this because the java looks sound.

@erinz2020
Copy link
Contributor Author

looks like this is missing the changes for the servletResponseTemplate.htm?

added. weird, I definitely updated this too earlier today

TanyaStere42
TanyaStere42 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

header state is reflected correctly for both configurations! 🎉

@TanyaStere42 TanyaStere42 merged commit ce5bc7f into main Dec 16, 2024
1 check passed
@TanyaStere42 TanyaStere42 deleted the 915_configurable_encounter_search branch December 16, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TanyaStere42 TanyaStere42 TanyaStere42 approved these changes

@naknomum naknomum naknomum approved these changes

Assignees

@erinz2020 erinz2020

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adapt encountersearch.jsp to be configurable
3 participants
@erinz2020 @naknomum @TanyaStere42