Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace hard-coded config values with properties settings #929

Merged
merged 16 commits into from
Dec 14, 2024
Merged

replace hard-coded config values with properties settings #929

merged 16 commits into from
Dec 14, 2024

Conversation

naknomum
Copy link
Member

@naknomum naknomum commented Dec 6, 2024 •
edited
Loading

basic OpenSearch settings can now be set via properties file

PR fixes #783

Changes

  • no longer hard-coded, will use OpenSearch.properties if available
  • defaults to original hard-coded values
  • OpenSearch.properties file added with example values
  • additional exception/shepherd handling improvements (thx @holmbergius )

naknomum and others added 16 commits December 6, 2024 13:00
@naknomum
wip
52df8e1
@holmbergius
Allow for reuse of single Shepherd to speed indexing
d803747
@holmbergius
Merge remote-tracking branch 'origin/783_opensearch_settings' into 78…
91767b5 
…3_opensearch_settings
@naknomum
config settings
4095265
@naknomum
Merge branch '783_opensearch_settings' of github.com:WildMeOrg/Wildbo…
4080a57 
…ok into 783_opensearch_settings
@naknomum
linting
1709b5e
@holmbergius
finish the close in this condition
8b13b36
@holmbergius
correct method name
43259d2
@holmbergius
close DB transaction and handle potential exceptions
103dd21
@holmbergius
Better backgrounding for unindex and exception handling for individua…
e0fa914 
…l indexing
@holmbergius
Move OpenSearch instantiation and its embedded http call into runnabl…
26af9a9 
…e thread for more nonblocking behavior and speed
@holmbergius
Send indexing out to threads
79058a9
@holmbergius
Switch these to deep for threading
2f9c07d
@naknomum
linting
da7bd44
@naknomum
Merge branch 'main' into 783_opensearch_settings
d8bbfeb
@naknomum
Merge branch 'main' into 783_opensearch_settings
3868b72
@naknomum naknomum marked this pull request as ready for review December 13, 2024 21:16
@naknomum naknomum requested a review from holmbergius December 13, 2024 21:16
holmbergius
holmbergius approved these changes Dec 14, 2024
View reviewed changes
Copy link
Contributor

@holmbergius holmbergius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look clean and conservative

@holmbergius holmbergius merged commit f5c1a9c into main Dec 14, 2024
1 check passed
@holmbergius holmbergius deleted the 783_opensearch_settings branch December 14, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmbergius holmbergius holmbergius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move hard-coded OpenSearch values into properties file
2 participants
@naknomum @holmbergius