Skip to content

Commit

Permalink
Merge pull request #213 from Wikia/COTECH-808
Browse files Browse the repository at this point in the history
COTECH-808 | eligible event
  • Loading branch information
latata authored Nov 29, 2023
2 parents b424c1a + ba04b60 commit a2cbc67
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 4 deletions.
2 changes: 2 additions & 0 deletions src/loaders/DesktopArticleVideoLoader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React, { useEffect, useState } from 'react';
import { DesktopArticleVideoLoaderProps } from 'loaders/types';
import { setVersionWindowVar } from 'loaders/utils/GetVersion';
import { getTakeoverDetails } from 'loaders/utils/GetTakeoverDetails';
import { eligibleTracker } from 'loaders/utils/tracking';

export { getVideoPlayerVersion } from 'loaders/utils/GetVersion';

Expand All @@ -14,6 +15,7 @@ export const DesktopArticleVideoLoader: React.FC<DesktopArticleVideoLoaderProps>
}

setVersionWindowVar();
eligibleTracker.impression();
}, []);

const getPlayer = async () => {
Expand Down
2 changes: 2 additions & 0 deletions src/loaders/MobileArticleVideoLoader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { MobileArticleVideoLoaderProps } from 'loaders/types';
import { setVersionWindowVar } from 'loaders/utils/GetVersion';
import { MobileArticleVideoContext } from 'contexts/MobileArticleVideoContext';
import { getTakeoverDetails } from 'loaders/utils/GetTakeoverDetails';
import { eligibleTracker } from 'loaders/utils/tracking';

export { getVideoPlayerVersion } from 'loaders/utils/GetVersion';

Expand All @@ -18,6 +19,7 @@ export const MobileArticleVideoLoader: React.FC<MobileArticleVideoLoaderProps> =
}

setVersionWindowVar();
eligibleTracker.impression();
}, []);

const getPlayer = async () => {
Expand Down
7 changes: 7 additions & 0 deletions src/loaders/utils/tracking.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import trackerFactory from '@fandom/tracking-metrics/tracking';

export const eligibleTracker = trackerFactory({
category: 'jwplayer',
event: 'eligible',
sendToDW: true,
});
8 changes: 4 additions & 4 deletions test-jw/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -504,10 +504,10 @@
version "0.0.0"
uid ""

"@fandom/tracking-metrics@0.0.28":
version "0.0.28"
resolved "https://artifactory.wikia-inc.com:443/artifactory/api/npm/wikia-npm/@fandom/tracking-metrics/-/@fandom/tracking-metrics-0.0.28.tgz#d35ca0ea3401bfd091e8f70102250e1c9da3441b"
integrity sha512-80cujNiaQGYcD37KrklLxPmO4WMafBi94mSPBAxowY1XqTRbUDizDCVxfQT8KR3zsejyXYdj5pf8+dp2Zn/HSg==
"@fandom/tracking-metrics@0.3.0":
version "0.3.0"
resolved "https://artifactory.wikia-inc.com:443/artifactory/api/npm/wikia-npm/@fandom/tracking-metrics/-/@fandom/tracking-metrics-0.3.0.tgz#9bcd7296893ec848c49e520ea560cf1472109fe2"
integrity sha512-Ur2js+2JbCCO/MCiGG660vNVUjI1UlshcTa6lNJ9ppsuz8KHQ3hHQfx/rvZBbneLQtMAZSAXEC/LdNT3kLjLpg==

"@floating-ui/core@^1.4.2":
version "1.5.0"
Expand Down

0 comments on commit a2cbc67

Please sign in to comment.