Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Calender not rendering correctly when creating a course. #5981

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

claire256
Copy link

@claire256 claire256 commented Oct 5, 2024

issue - #5701 (comment)

What this PR does

This PR is fixing the disable issue that was occurring when creating an Independent Program.

Screenshots

Before:
Screencast from 05-10-24 19:26:15.webm

After:
Screencast from 05-10-24 19:32:37.webm

@ragesoss
Copy link
Member

ragesoss commented Oct 7, 2024

Hmm...

This looks like an improvement. The system is supposed to enforce that event start/end dates are not outside of the range of activity tracking dates, but it looks like this only applies that to the start date, not the end date.

import DatePicker from '../common/date_picker.jsx';
import CourseUtils from '../../utils/course_utils.js';
import CourseDateUtils from '../../utils/course_date_utils.js';

const CourseDates = (props) => {
const [hasUpDatedDateProps, setHasUpDatedDateProps] = useState(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should use Updated rather than UpDated.

@claire256
Copy link
Author

Alright @ragesoss , Let me make the necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants