Skip to content

Commit

Permalink
[fixed] remove aria-modal attr to prevent browser bugs
Browse files Browse the repository at this point in the history
There were a couple problems with the aria-modal attribute:

- it was not set on the correct dom element (in theory, it should be
set on the element having the dialog role, as stated in reactjs#654)
- it is buggy in Safari. The easy way to fix the problem is to remove the attribute
(again, as suggested in reactjs#654). While it's cool on paper, the attribute is currently
not necessary, since the `aria-hidden="true"` is set correctly on the
app element.
  • Loading branch information
manuhabitela authored and diasbruno committed Jul 30, 2018
1 parent 4377cc8 commit 1e349c0
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/components/ModalPortal.js
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,6 @@ export default class ModalPortal extends Component {
style={{ ...overlayStyles, ...this.props.style.overlay }}
onClick={this.handleOverlayOnClick}
onMouseDown={this.handleOverlayOnMouseDown}
aria-modal="true"
>
<div
ref={this.setContentRef}
Expand Down

0 comments on commit 1e349c0

Please sign in to comment.