[EXTEND] Parse partial responses #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ear-dev
reviewed
Feb 11, 2022
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "devDependencies": { | |||
| "@rocket.chat/apps-engine": "WideChat/Rocket.Chat.Apps-engine.git#v1.29.2", | |||
| "@rocket.chat/apps-engine": "git+https://github.com/WideChat/Rocket.Chat.Apps-engine.git#dialogflow_branch", | |||
There was a problem hiding this comment.
NOTE: this is fine for testing, but we need to be careful that we revert or fix this before we merge.
ear-dev
reviewed
Feb 11, 2022
| @@ -28,11 +28,116 @@ | |||
| "js-tokens": "^4.0.0" | |||
| } | |||
| }, | |||
| "@google-cloud/dialogflow-cx": { | |||
There was a problem hiding this comment.
Do all of these things need to also go into package.json?
I'm seeing this error when I try to deploy with rc-apps:
Error: Cannot find module '@rocket.chat/apps-engine/node_modules/@google-cloud/dialogflow-cx'
There was a problem hiding this comment.
I have not found a way to remove that error. If I point the app to the correct location of the module, the app will not deploy.
With the current set-up we get the error, but the app can deploy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
Make sure that the correct version of apps-engine is installed by running
npm install @rocket.chat/apps-dialogflowCustom Payloads:
Partial responses will not be able to handle payloads that require sending additional requests to the DF agent for any non-FINAL responses (the final message of a stream).
Currently supported Custom Payloads: