Summer 2018 Code Tweaks #868
Conversation
TODO: If bold or italic is enabled and you choose a font that doesn't support either one, the font will refuse to load and throw a console error. Fix this.
Also, "Font loading..." appears in alert box now. The alertbox is also more sophisticated. TODO: Proper font weight/italic still doesn't show up in Player. Also, it's still impossible to choose alternative weights like Light or ExtraBold.
-I removed all effects, leaving only clean white shapes -I tweaked the designs of a few SVGs -I horizontally and vertically aligned the contents of each SVG
Now more consistent with others
Also added new info svg for the alert box
Also fixed bug where mousing over other menu bar options while one is open does not open those up. Using the menu bar is much more intuitive now.
Multiplication sign in inspector is buggy
This reverts commit c40cbf1.
Arial bold/italic is missing outside of the editor though, but I don't know how to fix this.
|
Hey Landon! Sorry to get back to you super late on this - wick development has been pretty hectic lately as @Luxapodular and I have been doing a lot of administrative work related to grant money and such. So here's the current situation with the editor: After trying to rewrite the editor from scratch a few months ago, I actually had to scrap that rewrite and try again. The editor that I'm currently working on here is actually a second rewrite, where the idea is that the GUI will use React, everything else will be a separate library/project (you'll see that the drawing tools, the timeline, the script/tick system etc. are now their own projects) SO, basically, the first rewrite I did was pretty much compatible with your changes here and I was planning on merging your changes into that one, but since the second rewrite is using React, the GUI is all completely new code written in jsx. However - the good news is that the changes you made to the CSS are still usable with React, and the fixes you added to the google font system should also still work. And of course, the graphical changes you did in various places (tool icons and such) can still be used. As long as work on the React editor continues at the same pace, I should be able to merge these fixes in the next few weeks. Anyway, sorry for all the difficulties with contributing to the editor, I'm still pretty new to maintaining big projects like this but I'm learning ~~!! 😬 |
|
@zrispo just as a recommendation it would be good to add some of that information in the README project and link the new repo there. I have few colleagues who thought the project is dead considering the issues count/response rate and the commit activity |
https://forum.wickeditor.com/t/wick-fork-with-new-ui-other-improvements/769
I made several commits to my fork over the summer, but I unfortunately never got around to making the actual pull request. 😞 Better late than never, though!
With the overhaul to Wick being previewed in just a few days, I'm not sure if accepting these changes would confuse users, but I wanted to make them accessible for you in case you wanted to implement any of these to the old Wick before the new one is stable. Enjoy! 😄
The default branch in my fork is called ‘all-improvements’ and it’s based on the upstream branch ‘151’.
Changes