Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default delay in requestPairingCode to avoid errors #937

Closed
wants to merge 3 commits into from

Conversation

vinikjkkj
Copy link
Contributor

sometimes its necessary to set a delay to avoid error requesting a pairing code when connection was not estabilished yet, the delay can be changed or removed

@whiskeysockets-bot
Copy link
Contributor

Thanks for your contribution.

The next step is to wait for review and approval to merge it to main repository

The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it.

To test this PR you can run the following command below:

# NPM
npm install @whiskeysockets/baileys@vinikjkkj/Baileys-Public#pairingcode-delay
# YARN v2
yarn add @whiskeysockets/baileys@vinikjkkj/Baileys-Public#pairingcode-delay

@DavidsonGomes
Copy link
Contributor

Here I already do this in the implementation of the function, I don't believe that this delay is the responsibility of the lib

@PurpShell PurpShell closed this Jul 26, 2024
@vinikjkkj
Copy link
Contributor Author

Here I already do this in the implementation of the function, I don't believe that this delay is the responsibility of the lib

There is no information in the documentation that it is necessary to use delay to request the code, new users will face problems and will not find the solution, opening unnecessary issues, at least it could include this in the documentation, you implemented this because you had problems that could have been avoided

@vinikjkkj vinikjkkj deleted the pairingcode-delay branch August 20, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants