-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incoming LID and sending LID #408
Conversation
Thanks for your contribution. The next step is to wait for review and approval to merge it to main repository The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it. To test this PR you can run the following command below:
|
… PLEASE I HAVE A FAMIL-
Aduh sepuh bisa aja |
Done a few testing on this PR. Sending using @lid from Baileys to user - PASS RequestPhoneNumber - PASS Receiving not appear in upsert event if user message - FAILED Test device - User 1: WA 2.23.20.74 Masked number only appear as privacy token |
in the future, we found traces that all businesses will talk to normal numbers through the LID. As a matter of fact, get a normal whatsapp lid right now, send a message to it through baileys in this PR through any business number. And you will not get their number, it'll be the same as the fb ads ctwa. |
Also, I had no issues over dozens of numbers receiving and sending events and messages, check if anything is wrong with your configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add lidJid as well in contacts.upsert here
ev.emit('contacts.upsert', [{ id, name: action.contactAction!.fullName!, lidJid: action.contactAction!.lidJid! }])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need, official whatsapp web launches a new conversation. it is up to you to change contact info or replace the chat id in your database.
This comment was marked as abuse.
This comment was marked as abuse.
Any news on this? Can an Admin review this PR, we actually need one more review for this to be approved. |
@Auties00 we can approve this first then can be fixed later for user still not be able to detect conversion from lid |
This comment was marked as abuse.
This comment was marked as abuse.
Original PR WhiskeySockets/Baileys#408 # Conflicts: # src/Socket/messages-send.ts # src/Utils/crypto.ts # src/Utils/messages.ts
Could you help me how can I send/receive a message using @lid to test this PR? Thanks |
This comment was marked as off-topic.
This comment was marked as off-topic.
up |
1 similar comment
up |
Up |
Have been testing this PR for a month and there isn't any breaking issue. +1 to merge this PR thanks! |
Big thank you to @canove and @whaticket for the help and resources.
This should fix chats incoming/outgoing with people with a hidden number.
If you'd like to thank me for my work, I have a GitHub Sponsors