Update getDevice #309
Closed
Update getDevice #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. The next step is to wait for review and approval to merge it to main repository The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it. To test this PR you can run the following command below: |
Ismananda
reviewed
Oct 4, 2023
| @@ -733,7 +733,7 @@ export const extractMessageContent = (content: WAMessageContent | undefined | nu | |||
| * Returns the device predicted by message ID | |||
| */ | |||
| export const getDevice = (id: string) => { | |||
| const deviceType = id.length > 21 ? 'android' : id.substring(0, 2) === '3A' ? 'ios' : 'web' | |||
| const deviceType = id.substring(0, 2) === '3E' ? 'web' : id.substring(0, 2) === '3A' ? 'ios' : 'android' | |||
There was a problem hiding this comment.
I think every android has an ID length of 32 and web always starts with 3EB0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before getDevice returned id that had above 21 characters as 'android', but whatsapp web messages were returned as 'android' too.
An example of a WhatsApp Web message id that returned android: "id": "3EB0F513CA2F3372B995CA", containing 22 characters (above 21 = android)
Now it's fixed