Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove label feature #1090

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jianhuihi
Copy link
Contributor

Changes

  • Removed all references to the label feature from relevant modules, including label management and associated functions.
  • Updated documentation to reflect the removal of this feature.
  • Cleaned up tests and removed any label-related test cases.
  • Ensured the system functions correctly without the label feature.

Motivation

As per the discussion in issue #1069, the label feature is no longer needed. Removing it helps in reducing code complexity and improving maintainability.

Testing

  • Verified that the removal does not break any existing functionality.
  • Passed all unit and integration tests.

Related Issues

Fixes #1069

@whiskeysockets-bot
Copy link
Contributor

Thanks for your contribution.

The next step is to wait for review and approval to merge it to main repository

The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it.

To test this PR you can run the following command below:

# NPM
npm install @whiskeysockets/baileys@jianhuihi/Baileys#removelabel
# YARN v2
yarn add @whiskeysockets/baileys@jianhuihi/Baileys#removelabel

@ImPedro29
Copy link

Functions to add and remove are not working to me

@jianhuihi
Copy link
Contributor Author

Functions to add and remove are not working to me

Are you using the WA Business version?

@ImPedro29
Copy link

ImPedro29 commented Nov 20, 2024

Are you using the WA Business version?

Yeah. I found the bug. If I connect baileys as a second device, events of labels are miss identified.
Im receiving 5~6 events of chat label removal, but in reality im adding a tag.
When baileys was the first device connected it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage Labels (Create, Update, Remove)
3 participants