Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling: add git hooks (through pre commit microframework) #11

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

Guts
Copy link
Collaborator

@Guts Guts commented Sep 5, 2024

Hola,

As discussed in #10, I'm starting to introduce some tooling to help consolidating the project before extending it with features and bug fixes.

This PR add configuration for pre-commit framework with classic hooks related to Python developing guidelines, regarding formatting and linting:

  • black
  • ruff
  • isort
  • flake8

The targetted Python version is the 3.9 which is the one embedded in QGIS for Windows <3.34.5.

Since applying it to the whole code base has a gude impact, it will be done on a next PR.


@Guts Guts changed the base branch from main to cleanup_2023 September 5, 2024 17:32
@kannes kannes changed the base branch from cleanup_2023 to main September 24, 2024 10:15
@kannes
Copy link
Contributor

kannes commented Sep 24, 2024

Nice, thank you!

This will be quite a bit of work to get the codebase to match the flake8 rules :D

@kannes kannes merged commit 1a7fd18 into WhereGroup:main Sep 24, 2024
@Guts
Copy link
Collaborator Author

Guts commented Sep 24, 2024

This will be quite a bit of work to get the codebase to match the flake8 rules :D

I guess but I've faith in some tools to help me!

@Guts Guts deleted the tooling/add-pre-commit branch September 24, 2024 11:39
@Guts Guts added the tooling Development tools label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Development tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants