Add CDSA imputation method #303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially achieved, not yet perfected
WenjieDu
added
enhancement
Update class names and comments
WenjieDu
reviewed
Jan 27, 2024
| self.d_k = d_k | ||
| self.d_v = d_v | ||
|
|
||
| # w_qs, w_ks for Time Dimension |
There was a problem hiding this comment.
w_qs_time, w_ks_time for the time dimension and w_qs_feature, w_ks_feature for the feature dimension are not used in the func forward().
WenjieDu
reviewed
Jan 27, 2024
| residual = v | ||
|
|
||
| # now separate the last dimension of q, k, v into different heads -> [batch_size, n_steps, n_heads, d_k or d_v] | ||
| q_time = self.w_qs(q_time).view(batch_size, n_steps, self.n_heads, self.d_k) |
There was a problem hiding this comment.
self.w_qs and w_ks are not initialized in the func init().
|
This pull request had no activity for 14 days. It will be closed in 1 week unless there is some new activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially achieved, not yet perfected
What does this PR do?
Add CDSA imputation method.
Initially achieved, not yet perfected.
Before submitting