Fix warnings

WeiqunZhang · Sep 27, 2024 · 73d9bc7 · 73d9bc7
1 parent 57a9864
commit 73d9bc7
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/.github/workflows/gcc.yml b/.github/workflows/gcc.yml
@@ -86,7 +86,7 @@ jobs:
  restore-keys: |
  ccache-${{ github.workflow }}-${{ github.job }}-git-
  - name: Build & Install
- env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -O1 -Wnon-virtual-dtor -Wlogical-op -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches -Wmissing-include-dirs"}
+ env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -O1 -Wnon-virtual-dtor -Wlogical-op -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches -Wmissing-include-dirs -Wno-null-dereference"}
  # It's too slow with -O0
  run: |
  export CCACHE_COMPRESS=1

diff --git a/Src/Particle/AMReX_Particle_mod_K.H b/Src/Particle/AMReX_Particle_mod_K.H
@@ -14,6 +14,12 @@ void amrex_deposit_cic (P const& p, int nc, amrex::Array4<amrex::Real> const& rh
  amrex::GpuArray<amrex::Real,AMREX_SPACEDIM> const& plo,
  amrex::GpuArray<amrex::Real,AMREX_SPACEDIM> const& dxi)
 {
+// GCC does not like rdata(comp)
+#if defined(__GNUC__) && !defined(__clang__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wno-array-bounds"
+#endif
+
 #if (AMREX_SPACEDIM == 1)
  amrex::Real lx = (p.pos(0) - plo[0]) * dxi[0] + Real(0.5);
 
@@ -101,6 +107,10 @@ void amrex_deposit_cic (P const& p, int nc, amrex::Array4<amrex::Real> const& rh
 #else
  amrex::Abort("Not implemented.");
 #endif
+
+#if defined(__GNUC__) && !defined(__clang__)
+#pragma GCC diagnostic pop
+#endif
 }
 
 template <typename P>
@@ -110,6 +120,12 @@ void amrex_deposit_particle_dx_cic (P const& p, int nc, amrex::Array4<amrex::Rea
  amrex::GpuArray<amrex::Real,AMREX_SPACEDIM> const& dxi,
  amrex::GpuArray<amrex::Real,AMREX_SPACEDIM> const& pdxi)
 {
+// GCC does not like rdata(comp)
+#if defined(__GNUC__) && !defined(__clang__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wno-array-bounds"
+#endif
+
 #if (AMREX_SPACEDIM == 1)
  amrex::Real factor = (pdxi[0]/dxi[0]);
 
@@ -230,6 +246,10 @@ void amrex_deposit_particle_dx_cic (P const& p, int nc, amrex::Array4<amrex::Rea
 #else
  amrex::Abort("Not implemented.")
 #endif
+
+#if defined(__GNUC__) && !defined(__clang__)
+#pragma GCC diagnostic pop
+#endif
 }
 
 }