Fix clang-tidy warning seen in incflo

WeiqunZhang · Jul 6, 2023 · 1e89f39 · 1e89f39
1 parent 7fed45f
commit 1e89f39
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/Src/Base/AMReX_PhysBCFunct.H b/Src/Base/AMReX_PhysBCFunct.H
@@ -179,9 +179,10 @@ public:
  }
 
  // For backward compatibility
- void FillBoundary (MultiFab& mf, int dcomp, int ncomp, IntVect const& nghost,
+ void FillBoundary (MultiFab& mf, int icomp, int ncomp, IntVect const& nghost,
  Real time, int bccomp) {
- this->operator()(mf,dcomp,ncomp,nghost,time,bccomp);
+ // NOLINTNEXTLINE(readability-suspicious-call-argument)
+ this->operator()(mf,icomp,ncomp,nghost,time,bccomp);
  }
 
 private:

diff --git a/Src/EB/AMReX_EB2.H b/Src/EB/AMReX_EB2.H
@@ -118,12 +118,12 @@ Build (const G& gshop, const Geometry& geom,
  int num_coarsen_opt = NumCoarsenOpt())
 {
  BL_PROFILE("EB2::Initialize()");
- IndexSpace::push(new IndexSpaceImp<G>(gshop, geom,
+ IndexSpace::push(new IndexSpaceImp<G>(gshop, geom, // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
  required_coarsening_level,
  max_coarsening_level,
  ngrow, build_coarse_level_by_coarsening,
  extend_domain_face,
- num_coarsen_opt)); // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
+ num_coarsen_opt));
 }
 
 void Build (const Geometry& geom,

diff --git a/Src/EB/AMReX_EB2.cpp b/Src/EB/AMReX_EB2.cpp
@@ -216,14 +216,14 @@ Build (const Geometry& geom, int required_coarsening_level,
  pp.queryAdd("stl_center", stl_center);
  int stl_reverse_normal = 0;
  pp.queryAdd("stl_reverse_normal", stl_reverse_normal);
- IndexSpace::push(new IndexSpaceSTL(stl_file, stl_scale,
+ IndexSpace::push(new IndexSpaceSTL(stl_file, stl_scale, // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
  {stl_center[0], stl_center[1], stl_center[2]},
  stl_reverse_normal,
  geom, required_coarsening_level,
  max_coarsening_level, ngrow,
  build_coarse_level_by_coarsening,
  a_extend_domain_face,
- a_num_coarsen_opt)); // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
+ a_num_coarsen_opt));
  }
  else
  {
@@ -247,11 +247,11 @@ BuildFromChkptFile (std::string const& fname,
  bool a_extend_domain_face)
 {
  ChkptFile chkpt_file(fname);
- IndexSpace::push(new IndexSpaceChkptFile(chkpt_file,
+ IndexSpace::push(new IndexSpaceChkptFile(chkpt_file, // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
  geom, required_coarsening_level,
  max_coarsening_level, ngrow,
  build_coarse_level_by_coarsening,
- a_extend_domain_face)); // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
+ a_extend_domain_face));
 }
 
 namespace {