add google checks

WeiqunZhang · Aug 4, 2023 · 00c08aa · 00c08aa
1 parent 0055f3e
commit 00c08aa
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 9 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -20,6 +20,9 @@ Checks: >
  -cppcoreguidelines-non-private-member-variables-in-classes,
  -cppcoreguidelines-owning-memory,
  -cppcoreguidelines-pro-*,
+ google-build-explicit-make-pair,
+ google-build-namespaces,
+ google-global-names-in-headers,
  misc-*,
  -misc-const-correctness,
  -misc-non-private-member-variables-in-classes,

diff --git a/Src/Base/AMReX_ParallelDescriptor.H b/Src/Base/AMReX_ParallelDescriptor.H
@@ -898,8 +898,7 @@ ParallelDescriptor::Bcast (T* t,
 #ifdef BL_LAZY
  int r;
  MPI_Comm_compare(comm, Communicator(), &r);
- if (r == MPI_IDENT)
- Lazy::EvalReduction();
+ if (r == MPI_IDENT) { Lazy::EvalReduction(); }
 #endif
 
  BL_ASSERT(n < static_cast<size_t>(std::numeric_limits<int>::max()));

diff --git a/Src/Base/AMReX_ParallelDescriptor.cpp b/Src/Base/AMReX_ParallelDescriptor.cpp
@@ -471,8 +471,7 @@ Barrier (const MPI_Comm &comm, const std::string &message)
 #ifdef BL_LAZY
  int r;
  MPI_Comm_compare(comm, Communicator(), &r);
- if (r == MPI_IDENT)
- Lazy::EvalReduction();
+ if (r == MPI_IDENT) { Lazy::EvalReduction(); }
 #endif
 
  BL_PROFILE_S("ParallelDescriptor::Barrier(comm)");
@@ -1130,8 +1129,7 @@ Bcast(void *buf, int count, MPI_Datatype datatype, int root, MPI_Comm comm)
 #ifdef BL_LAZY
  int r;
  MPI_Comm_compare(comm, Communicator(), &r);
- if (r == MPI_IDENT)
- Lazy::EvalReduction();
+ if (r == MPI_IDENT) { Lazy::EvalReduction(); }
 #endif
 
  BL_PROFILE_S("ParallelDescriptor::Bcast(viMiM)");

diff --git a/Tests/Amr/Advection_AmrLevel/Exec/SingleVortex/Prob_Parm.H b/Tests/Amr/Advection_AmrLevel/Exec/SingleVortex/Prob_Parm.H
@@ -3,8 +3,6 @@
 
 #include <AMReX_REAL.H>
 
-using namespace amrex::literals;
-
 // Define the struct to contain problem-specific variables here.
 // For this case, since we don't need any, the struct is empty.
 struct ProbParm {};

diff --git a/Tests/EB/CNS/Source/CNS.H b/Tests/EB/CNS/Source/CNS.H
@@ -5,7 +5,6 @@
 #include <AMReX_EBCellFlag.H>
 #include <AMReX_EBFluxRegister.H>
 
-using namespace amrex;
 class CNS
  :
  public amrex::AmrLevel