Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for component's category attribute #471

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

m-aciek
Copy link
Contributor

@m-aciek m-aciek commented Sep 7, 2023

Proposed changes

Expose component's category attribute in the Python API.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

@m-aciek m-aciek changed the title Add support for component's priority attribute Add support for component's category attribute Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #471 (e36f5f6) into main (c83a9a5) will decrease coverage by 0.12%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
- Coverage   98.97%   98.86%   -0.12%     
==========================================
  Files           6        6              
  Lines        1655     1669      +14     
  Branches      217      217              
==========================================
+ Hits         1638     1650      +12     
- Misses          8       10       +2     
  Partials        9        9              
Files Changed Coverage
wlc/test_base.py ø
wlc/__init__.py 100.00%
wlc/test_wlc.py 100.00%

wlc/__init__.py Show resolved Hide resolved
@m-aciek m-aciek marked this pull request as draft September 9, 2023 22:18
@m-aciek m-aciek marked this pull request as ready for review September 10, 2023 20:45
@nijel nijel merged commit f6a19fa into WeblateOrg:main Sep 11, 2023
23 of 24 checks passed
@nijel
Copy link
Member

nijel commented Sep 11, 2023

Merged, thanks for your contribution!

@nijel nijel self-assigned this Sep 11, 2023
@m-aciek m-aciek deleted the component-category branch September 11, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants