Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auditlog: skip notification for admin triggered account removal #9986

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

nijel
Copy link
Member

@nijel nijel commented Sep 19, 2023

Proposed changes

This leaks admin IP address to the user.

Fixes #9983

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.1 milestone Sep 19, 2023
@nijel nijel self-assigned this Sep 19, 2023
@nijel nijel enabled auto-merge (rebase) September 19, 2023 11:44
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #9986 (9a54380) into main (15059e5) will not change coverage.
Report is 34 commits behind head on main.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9986   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         533      533           
  Lines       55305    55305           
  Branches     8780     8780           
=======================================
  Hits        50291    50291           
  Misses       3484     3484           
  Partials     1530     1530           
Files Changed Coverage
weblate/accounts/models.py ø
weblate/accounts/views.py 0.00%
weblate/accounts/utils.py 100.00%

@nijel nijel merged commit 190df6e into WeblateOrg:main Sep 19, 2023
23 of 24 checks passed
@nijel nijel deleted the audit-notify branch September 19, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Administrative user removal triggers account activity email
1 participant