feat(tools): add search preview to bulk edit tool #12957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nijel
reviewed
Nov 7, 2024
weblate/trans/forms.py
Outdated
| @@ -2623,6 +2624,7 @@ class BulkEditForm(forms.Form): | |||
| def __init__(self, user: User | None, obj, *args, **kwargs) -> None: | |||
| project = kwargs.pop("project", None) | |||
| kwargs["auto_id"] = "id_bulk_%s" | |||
| kwargs["initial"] = {"path": obj.full_slug} | |||
There was a problem hiding this comment.
obj can be None here (when invoked from add-on configuration) and it then fails: AttributeError: 'NoneType' object has no attribute 'full_slug'
There was a problem hiding this comment.
Thanks, was not aware of there also being a bulk edit in the add-ons 🙈
There was a problem hiding this comment.
Passing blank path and not using it in lookup should do the trick in that case.
There was a problem hiding this comment.
I added a fix for this, please review.
The search preview is not activated on the add-on pages for bulk edit.
nijel
added a commit
to nijel/weblate
that referenced
this pull request
Nov 7, 2024
Correctly use project scoping when available, see WeblateOrg#12957
5 tasks
nijel
added a commit
to nijel/weblate
that referenced
this pull request
Nov 7, 2024
Correctly use project scoping when available, see WeblateOrg#12957
nijel
added a commit
to nijel/weblate
that referenced
this pull request
Nov 7, 2024
Correctly use project scoping when available, see WeblateOrg#12957
nijel
added a commit
that referenced
this pull request
Nov 7, 2024
Correctly use project scoping when available, see #12957
michael-smt
force-pushed
the
ui-bulk-edit-search-preview
branch
from
84593a1
to
7f91ae3
Compare
michael-smt
changed the title
nijel
reviewed
Nov 8, 2024
|
Merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds the same search preview from Search and replace to the Bulk edit tool.
Checklist
Other information
Related to #4106, #4108 and #7563.
Does not affect the Bulk edit add-on.