Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): add missing "type" attribute to button element #12890

Merged

Conversation

meel-hd
Copy link
Collaborator

@meel-hd meel-hd commented Oct 30, 2024

Proposed changes

Prevent wrong submit of add new translation form when clicking on the special chars toolbar.

the toolbar consists of buttons which defaults to type submit when embedded inside a from, which is incorrect in this case.
closes: #12761

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

Prevent wrong submit of add new translation form when clicking on the special chars toolbar.

the toolbar consists of buttons which defaults to type submit when embedded inside a from, which is incorrect in this case.
@nijel nijel added this to the 5.8.2 milestone Oct 30, 2024
@nijel nijel enabled auto-merge (rebase) October 30, 2024 13:58
@nijel nijel merged commit 5142be7 into WeblateOrg:main Oct 30, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking the custom special keys bar submits the Add New Translation String form
2 participants