checks: avoid reused check to trigger on blank strings

Fixes #9805
WeblateOrg · Aug 25, 2023 · f3ee140 · f3ee140
1 parent 2457899
commit f3ee140
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/docs/changes.rst b/docs/changes.rst
@@ -12,6 +12,7 @@ Not yet released.
 * Creating component within a category.
 * Source strings and state display for converted formats.
 * Block :ref:`component-edit_template` on formats which do not support it.
+* :ref:`check-reused` is no longer triggered for blank strings.
 
 **Compatibility**
 

diff --git a/weblate/checks/consistency.py b/weblate/checks/consistency.py
@@ -164,7 +164,7 @@ def get_propagated_units(self, unit, target: str | None = None):
         return Unit.objects.same_target(unit, target)
 
     def should_skip(self, unit):
-        if unit.translation.plural.number <= 1:
+        if unit.translation.plural.number <= 1 or not any(unit.get_target_plurals()):
             return True
         return super().should_skip(unit)
 
@@ -201,6 +201,7 @@ def check_component(self, component):
             translation__component__allow_translation_propagation=True,
             state__gte=STATE_TRANSLATED,
         )
+        units = units.exclude(target="")
 
         # List strings with different sources
         # Limit this to 100 strings, otherwise the resulting query is way too complex