Proxy: change default offset to take final IP

As recommended by https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For#security_and_privacy_concerns
WeblateOrg · Sep 5, 2023 · 4efa977 · 4efa977
1 parent 8a7718b
commit 4efa977
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/weblate/settings_docker.py b/weblate/settings_docker.py
@@ -1001,7 +1001,7 @@
 # Reverse proxy settings
 IP_PROXY_HEADER = get_env_str("WEBLATE_IP_PROXY_HEADER")
 IP_BEHIND_REVERSE_PROXY = bool(IP_PROXY_HEADER)
-IP_PROXY_OFFSET = 0
+IP_PROXY_OFFSET = -1
 
 # Sending HTML in mails
 EMAIL_SEND_HTML = True

diff --git a/weblate/settings_example.py b/weblate/settings_example.py
@@ -669,7 +669,7 @@
 # Reverse proxy settings
 IP_PROXY_HEADER = "HTTP_X_FORWARDED_FOR"
 IP_BEHIND_REVERSE_PROXY = False
-IP_PROXY_OFFSET = 0
+IP_PROXY_OFFSET = -1
 
 # Sending HTML in mails
 EMAIL_SEND_HTML = True

diff --git a/weblate/trans/models/_conf.py b/weblate/trans/models/_conf.py
@@ -146,7 +146,7 @@ class WeblateConf(AppConf):
     # Rate limiting
     IP_BEHIND_REVERSE_PROXY = False
     IP_PROXY_HEADER = "HTTP_X_FORWARDED_FOR"
-    IP_PROXY_OFFSET = 0
+    IP_PROXY_OFFSET = -1
 
     # Authentication
     AUTH_TOKEN_VALID = 172800