fix(gitexporter): avoid manually building query string

WeblateOrg · Nov 16, 2024 · 264feaa · 264feaa
1 parent efe53d8
commit 264feaa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/weblate/gitexport/tests.py b/weblate/gitexport/tests.py
@@ -84,7 +84,7 @@ def test_git_info(self) -> None:
     def git_receive(self, **kwargs):
         return self.client.get(
             self.get_git_url(),
-            QUERY_STRING="?service=git-upload-pack",
+            {"service": "git-upload-pack"},
             CONTENT_TYPE="application/x-git-upload-pack-advertisement",
             **kwargs,
         )
@@ -93,7 +93,7 @@ def test_redirect_link(self) -> None:
         linked = self.create_link_existing()
         response = self.client.get(
             self.get_git_url(component=linked),
-            QUERY_STRING="?service=git-upload-pack",
+            {"service": "git-upload-pack"},
             CONTENT_TYPE="application/x-git-upload-pack-advertisement",
         )
         self.assertRedirects(

diff --git a/weblate/gitexport/views.py b/weblate/gitexport/views.py
@@ -95,7 +95,7 @@ def git_export(request: AuthenticatedHttpRequest, path, git_request):
         raise Http404("Not a git repository")
     if obj.is_repo_link:
         return redirect(
-            "{}{}".format(
+            "{}?{}".format(
                 reverse(
                     "git-export",
                     kwargs={