Fix #26 - Avoid notifying unassigned SharedArrayBuffer entry #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR avoids a very subtle bug that is hard to repeat consistently but that, to my understanding, boils down to this issue:
[0]
thenAtomics.wait(sb, 0, 0, delay)
might fail unexpectedly without any warning whatsoever[0]
then everything always works as expected[0]
it always works tooI have no idea if it's worth it to me to file a bug to all vendors as I think this is an intended behavior.
Changes
undefined
) a value at index[0]
is set as-1
so that negative result length means no further actions need to be performedlength
is indeed less than zero, early return without asking for data to unserialize