forked from buildroot/buildroot
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DropbearServerPlugin] Initial version for review #121
Open
s-rapolu
wants to merge
19
commits into
WebPlatformForEmbedded:master
Choose a base branch
from
s-rapolu:srapolu/dropbear
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
cf38a01
Initial commit for DropbearServer plugin
s-rapolu 8d9d73f
[DropbearServerPlugin]Made build changes to support both Dropbear sha…
s-rapolu 0d6215b
[DropbearServerPlugin]Session management support in native Dropbear c…
s-rapolu dc1264f
[DropbearServerPlugin] Fixes to the session management implementation…
s-rapolu cfa9912
[DropbearServerPlugin] Fixes to RPC implementation of Dropbear plugin
s-rapolu 6152680
[DropbearServerPlugin] Fix for dropbear configuration issue
s-rapolu 2721a4d
[DropbearServerPlugin] Fix for finding dropbear shared library at cor…
s-rapolu 8eb3db7
[DropbearServerPlugin] Fix for closing client connections
s-rapolu 5e91eb4
[SecureShellServerPlugin] Removed separate JSON RPC methods as per co…
s-rapolu 1c67d20
[SecureShellServerPlugin] Changes made to native dropbear implementation
s-rapolu d15fa4f
[SecureShellServerPlugin] fixed issues with native dropbear
s-rapolu 33a89b0
[SecureShellServerPlugin] enable SSH plugin through defaults
s-rapolu 7b3883a
Merge branch 'master' into srapolu/dropbear
s-rapolu fd24449
[SecureShellServerPlugin] IClient interface implementation
s-rapolu 5b8da33
[SecureShellServerPlugin] updated dropbear patches with git format-patch
s-rapolu 0ac6564
[SecureShellServerPlugin] changed the position of SecureShellServer b…
s-rapolu 03467b1
[SecureShellServerPlugin] updated native dropbear with mutex lock
s-rapolu de980e1
[SecureShellServerPlugin] fixed issues related to session management
s-rapolu 3b8989e
[SecureShellServerPlugin] revert the changes done for wpeframework.mk…
s-rapolu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
package/dropbear/0001-Makefile.in-changes.patch.conditional
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
--- a/Makefile.in 2016-07-21 20:47:09.000000000 +0530 | ||
+++ b/Makefile.in 2019-06-07 15:08:42.613982883 +0530 | ||
@@ -10,7 +10,7 @@ | ||
# Hopefully that seems intuitive. | ||
|
||
ifndef PROGRAMS | ||
- PROGRAMS=dropbear dbclient dropbearkey dropbearconvert | ||
+ PROGRAMS=dropbear | ||
endif | ||
|
||
STATIC_LTC=libtomcrypt/libtomcrypt.a | ||
@@ -18,6 +18,8 @@ | ||
|
||
LIBTOM_LIBS=@LIBTOM_LIBS@ | ||
|
||
+DROPBEAR_SERVER_LIB=libdropbear.so | ||
+ | ||
ifeq (@BUNDLED_LIBTOM@, 1) | ||
LIBTOM_DEPS=$(STATIC_LTC) $(STATIC_LTM) | ||
CFLAGS+=-I$(srcdir)/libtomcrypt/src/headers/ | ||
@@ -75,6 +77,9 @@ | ||
bindir=@bindir@ | ||
sbindir=@sbindir@ | ||
mandir=@mandir@ | ||
+libdir = @libdir@ | ||
+includedir = @includedir@ | ||
+pkgconfigdir = $(libdir)/pkgconfig | ||
|
||
CC=@CC@ | ||
AR=@AR@ | ||
@@ -82,9 +87,10 @@ | ||
STRIP=@STRIP@ | ||
INSTALL=@INSTALL@ | ||
CPPFLAGS=@CPPFLAGS@ | ||
-CFLAGS+=-I. -I$(srcdir) $(CPPFLAGS) @CFLAGS@ | ||
+CFLAGS+=-I. -I$(srcdir) $(CPPFLAGS) @CFLAGS@ -fPIC | ||
LIBS+=@LIBS@ | ||
LDFLAGS=@LDFLAGS@ | ||
+ARFLAGS=rcT | ||
|
||
EXEEXT=@EXEEXT@ | ||
|
||
@@ -106,12 +112,14 @@ | ||
|
||
ifeq ($(STATIC), 1) | ||
LDFLAGS+=-static | ||
+else | ||
+ LDFLAGS +=-shared | ||
endif | ||
|
||
ifeq ($(MULTI), 1) | ||
TARGETS=dropbearmulti | ||
else | ||
- TARGETS=$(PROGRAMS) | ||
+ TARGETS=$(DROPBEAR_SERVER_LIB) | ||
endif | ||
|
||
# for the scp progress meter. The -D doesn't affect anything else. | ||
@@ -175,6 +183,8 @@ | ||
scp: $(SCPOBJS) $(HEADERS) Makefile | ||
$(CC) $(LDFLAGS) -o $@$(EXEEXT) $(SCPOBJS) | ||
|
||
+$(DROPBEAR_SERVER_LIB):$(LIBTOM_LIBS)$(dropbearobjs) | ||
+ $(CC) $(LDFLAGS) -o $@ $(dropbearobjs) $(LIBTOM_LIBS) | ||
|
||
# multi-binary compilation. | ||
MULTIOBJS= | ||
@@ -215,7 +225,7 @@ | ||
|
||
thisclean: | ||
-rm -f dropbear dbclient dropbearkey dropbearconvert scp scp-progress \ | ||
- dropbearmulti *.o *.da *.bb *.bbg *.prof | ||
+ dropbearmulti *.o *.da *.bb *.bbg *.prof libdropbear.pc $(DROPBEAR_SERVER_LIB) | ||
|
||
distclean: clean tidy | ||
-rm -f config.h |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch needs appropriate format-patch header, including commit log providing a reason for the patch. For more info see: https://git-scm.com/docs/git-format-patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, made the corrections and now created the patch with git format-patch header.