Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AllowWebGLInWorkers only if WEBGL is enabled #1443

Open
wants to merge 1 commit into
base: wpe-2.46
Choose a base branch
from
Open

Use AllowWebGLInWorkers only if WEBGL is enabled #1443

wants to merge 1 commit into from

Conversation

spenap
Copy link

@spenap spenap commented Dec 17, 2024 •
edited by ews-bot-wpe-rdk
Loading

Downstream commit 09ee201 implements NonCompositedWebGL. In there, DrawingAreaCoordinatedGraphics.cpp unconditionally tries to invoke setAllowWebGLInWorkers which won't exist as the property is only exposed when WEBGL is enabled.

This commit fixes it, protecting the setting behind the same guard.
ac956af

Build-Tests Layout-Tests
✅ 🛠 wpe-246-amd64-build ✅ 🧪 wpe-246-amd64-layout
✅ 🛠 wpe-246-arm32-build ✅ 🧪 wpe-246-arm32-layout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magomez magomez Awaiting requested review from magomez magomez is a code owner

@zdobersek zdobersek Awaiting requested review from zdobersek zdobersek is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@spenap