[MessageControl] Fixing UDP output and allowing it to store more than one message #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeithMetro
changed the title
sebaszm
approved these changes
Sep 19, 2024
|
The 4KB value seems arbitrary, but I understand it needs to accommodate asynchronous flushing of the data through the network. |
pwielders
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like we discussed on Teams with @sebaszm, there are two major changes:
Convert()as all other Publishers, since it has not been updated up to this point_sendBuffer, since theTrigger()call is asynchronous. With Thunder already running, theSendData()method is called on average once every 1-3 calls of the Output() method, but when the framework starts, it can take quite a while before the first buffer "flush" happens (hence 4KB size, since I was still getting an ASSERT with 2KB)