Skip to content

Commit

Permalink
Removing instantiation of LoggerFactory that occurs after specialization
Browse files Browse the repository at this point in the history
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PerformanceMetrics/TraceOutput.cpp:229:89: error: explicit instantiation of 'LoggerFactory<Thunder::Plugin::PerformanceMetrics::IBrowserMetricsLogger>' that occurs after an explicit specialization has no effect [-Werror,-Winstantiation-after-specialization]
template std::unique_ptr<PerformanceMetrics::IBrowserMetricsLogger> PerformanceMetrics::LoggerFactory<PerformanceMetrics::IBrowserMetricsLogger>();                
                                                                                        ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PerformanceMetrics/TraceOutput.cpp:223:80: note: previous template specialization is here
std::unique_ptr<PerformanceMetrics::IBrowserMetricsLogger> PerformanceMetrics::LoggerFactory<PerformanceMetrics::IBrowserMetricsLogger>() {
  • Loading branch information
VeithMetro authored Nov 13, 2024
1 parent 9a598a3 commit 2913a15
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion PerformanceMetrics/TraceOutput.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,6 @@ std::unique_ptr<PerformanceMetrics::IBrowserMetricsLogger> PerformanceMetrics::L

template std::unique_ptr<PerformanceMetrics::IBasicMetricsLogger> PerformanceMetrics::LoggerFactory<PerformanceMetrics::IBasicMetricsLogger>();
template std::unique_ptr<PerformanceMetrics::IStateMetricsLogger> PerformanceMetrics::LoggerFactory<PerformanceMetrics::IStateMetricsLogger>();
template std::unique_ptr<PerformanceMetrics::IBrowserMetricsLogger> PerformanceMetrics::LoggerFactory<PerformanceMetrics::IBrowserMetricsLogger>();

}
}

0 comments on commit 2913a15

Please sign in to comment.