Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of isith and nsith to include array of string #103

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

psteniusubi
Copy link
Contributor

Adding string[] to type union to allow assigning isith and nsith value such as ["1/2", "1/2"]

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #103 (7c41432) into development (594610e) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #103   +/-   ##
============================================
  Coverage        80.40%   80.40%           
============================================
  Files               35       35           
  Lines             3751     3751           
  Branches           835      835           
============================================
  Hits              3016     3016           
  Misses             710      710           
  Partials            25       25           
Files Changed Coverage Δ
src/keri/app/signify.ts 90.69% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@m00sey m00sey merged commit 51db099 into WebOfTrust:development Sep 8, 2023
4 checks passed
@psteniusubi psteniusubi deleted the fix-sith-type branch September 22, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants