feat: tel state noticer to query for tel updates #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iFergal
commented
Sep 24, 2024
src/keri/vdr/eventing.py
Outdated
| if ri in self.tevers: | ||
| tever = self.tevers[ri] | ||
| tsn = tever.state() | ||
| self.cues.push(dict(kin="reply", route="/tsn/registry", data=asdict(tsn), dest=source)) | ||
| self.cues.push(dict(kin="reply", route=f"/tsn/registry/{src}", data=asdict(tsn), dest=source.qb64)) |
There was a problem hiding this comment.
Curious if we should just skip this if vci is set below, depends on if we need to escrow or not
| @@ -2007,12 +1994,8 @@ def processEscrows(self): | |||
| extype=kering.MissingRegistryError) | |||
| self.reger.txnsb.processEscrowState(typ="credential-mae", processReply=self.processReplyCredentialTxnState, | |||
| extype=kering.MissingAnchorError) | |||
| self.reger.txnsb.processEscrowState(typ="credential-ooo", processReply=self.processReplyCredentialTxnState, | |||
There was a problem hiding this comment.
If this change is right, maybe we should also remove the credential-mre escrow, not sure.
| sraw = self.reger.getTvt(key=dgKey(pre=regk, dig=ldig)) | ||
| # assumes db ensures that sraw must not be none because sdig was in KE | ||
| sserder = serdering.SerderKERI(raw=bytes(sraw)) | ||
| if ldig is not None: # escrow because event does not yet exist in database |
m00sey
added
documentation
|
@pfeairheller can you advise if this change to make tsn match ksn is on the right path? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards TEL Observers - made some changes to make TSN behave same as KSN with a noticer that will fetch any remaining items.
This isn't fully complete as I need some feedback - I'm really not sure if we are meant to escrow notices of new events that we haven't received yet.
Looking back in the history, we did this for KSN too but changed it in #441 and #538 so thinking it might make sense for TSN to behave the same way so that we can have efficient TEL observers. So I've made some changes there to be more like KSN.
If this isn't the right approach, we need to do something to trigger fetching of tels - the
telquerycalls for escrows aren't right atm for the same reason as #865 - no src so messages are never sent.