Restart the spiral iterator of the Multiply test when maxing out the grid size #53
Conversation
| * THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| class SpiralIterator { |
There was a problem hiding this comment.
I don't think this justifies its own JS file; it seems specific enough to Multiply that you should just put it in multiply.js.
There was a problem hiding this comment.
The class is moved to multiply.js.
| @@ -320,6 +343,9 @@ Point = Utilities.createClass( | |||
| } | |||
| }); | |||
|
|
|||
| // FIXME: Add a seprate class for Size. | |||
There was a problem hiding this comment.
Given all the comments you had to add above, maybe just do this.
There was a problem hiding this comment.
I tried but the result was more involved. The problem are with add(), subtract() and multiply(). These methods expects Point, Size or just a Number. With Point act as Size, we have to deal with the Number as a special case.
So let's have this be fixed in a separate change.
| @@ -24,120 +24,183 @@ | |||
| */ | |||
| (function() { | |||
|
|
|||
| class Tile { | |||
There was a problem hiding this comment.
The rest of the code doesn't yet use class syntax so I'm not sure this should yet.
There was a problem hiding this comment.
The ES6 class is removed and Utilities.createClass() is used instead. However this way is not great. Utilities.createClass() allows only one level of inheritance. I wanted to add a second level of inheritance between Stage and MultiplyStage
Stage
ReusableParticlesStage
MultiplyStage
I wanted to emphasize that the elements of Multiply are reusable. They are shown and hidden instead of created and removed. But I could not do that because Utilities.createClass() extends the prototype of the subclass with the prototype of the superclass only. It does not do that recursively. There might be tricky way to still do it. But I could not figure it out.
| @@ -0,0 +1,968 @@ | |||
| // Copyright 2014 Google Inc. All rights reserved. | |||
There was a problem hiding this comment.
Unit tests are great but let's not add a bunch of testing code in a small incremental update.
There was a problem hiding this comment.
Unit test is removed
| @@ -0,0 +1,58 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
I don't think this is necessary unless SpiralIterator gets used in more than Multiply.
There was a problem hiding this comment.
The whole directory for unit test is removed.
| let columnsCount = Math.floor(this.size.width / this.tileSize.width); | ||
| if (columnsCount % 2 == 0) | ||
| --columnsCount; | ||
| this.tileGrid = new Size(columnsCount, this.rowsCount); |
There was a problem hiding this comment.
When running this the visual jumps in the size of the grid feel like a bug. Is it possible to keep the visual rectangular size the same?
There was a problem hiding this comment.
Yes this can be done if the spiral iterator is restarted instead of having it enlarged. This will create layers of elements every time the spiral iterator is restarted. The opacity of the rounded rect tile can be a factor of its z-index and its distance from the center.
But this might be behavioral change and the score can be different. Are we okay with that?
There was a problem hiding this comment.
I implemented the restarting solution. And I made the rowsCount to be 59 always. Once the test maxes out the grid size it will create a new iterator.
@sky2 please try this solution. If you do not see the layers of elements on your machine change the rowsCount to be a smaller value.
There was a problem hiding this comment.
I like this one better in that the visual size of the grid doesn't jump around. thanks.
shallawa
force-pushed
the
eng/Fix-Multiply-maxing-out
branch
2 times, most recently
from
c73e13c
to
3151355
Compare
…grid size WebKit#52 Refactor the spiral iterator into a separate class. Keep calling its next() method to get the coordinates ofthe next cell. When its isDone() returns true create a new iterator and make the tiles of upper layers have less lightness than the ones on the lower layers. Add a new class for the roundedRect tile called "Tile". This class can handle the location, size and animation of the Tile.
shallawa
force-pushed
the
eng/Fix-Multiply-maxing-out
branch
from
3151355
to
9307820
Compare
shallawa
changed the title
#52
Refactor the spiral iterator into a separate class. Keep calling its next() method to get the coordinates ofthe next cell. When its isDone() returns true create a new iterator and make the tiles of upper layers have less lightness than the ones on the lower layers.
Add a new class for the roundedRect tile called "Tile". This class can handle the location, size and animation of the Tile.