Use JS class syntax in harness code #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert the harness code (and a bit of test code) to use JS class syntax, replacing `Utilities.createClass()` and `Utilities.createSubclass` with `class` and `extend`, fixing the formatting as appropriate. Mostly mechanical, other than passing `window.location` to `Utilities.parseParameters` so it doesn't depend on the current window object, and fixing a `this` access in `calculateScore()`. Some of these classes, like `Point`, are used in test code, so this may have some impact on test score.
smfr
added
the
non-trivial
|
Marked "non-trivial" since the changes touch test code. |
rniwa
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the harness code (and a bit of test code) to use JS class syntax, replacing
Utilities.createClass()andUtilities.createSubclasswithclassandextend, fixing the formatting as appropriate.Mostly mechanical, other than passing
window.locationtoUtilities.parseParametersso it doesn't depend on the current window object, and fixing athisaccess incalculateScore().Some of these classes, like
Point, are used in test code, so this may have some impact on test score.