generated from WebAssembly/wasi-proposal-template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some low level tests #19
Merged
Merged
Commits on Jan 23, 2023
-
``` (venv) spacetanuki% TOYWASM=~/git/toywasm/b/toywasm python3 test-runner/wasi_test_runner.py -t ~/git/wasm/wasi-threads/test/testsuite -r ~/git/toywasm/test/wasi-testsuite-adapter.py Test wasi_threads_exit_nonmain_wasi passed Test wasi_threads_exit_main_busy passed Test wasi_threads_exit_main_wasi passed Test wasi_threads_exit_nonmain_busy passed Test wasi_threads_spawn passed Test wasi_threads_exit_main_block passed Test wasi_threads_exit_nonmain_block passed ===== Test results ===== Runtime: toywasm v0.0 Suite: WASI threads proposal Total: 7 Passed: 7 Failed: 0 Test suites: 1 passed, 0 total Tests: 7 passed, 0 total (venv) spacetanuki% ```
Configuration menu - View commit details
-
Copy full SHA for 4ad2f95 - Browse repository at this point
Copy the full SHA 4ad2f95View commit details -
import shared memory in wat tests
as suggested in WebAssembly/wasi-libc#369 the corresponding toywasm change: yamt/toywasm@4d81846 ``` spacetanuki% TOYWASM=~/git/toywasm/b/toywasm python3 ~/git/wasm/wasi-testsuite/test-runner/wasi_test_runner.py -t ./test/testsuite -r ~/git/toywasm/test/wasi-testsuite-adapter.py Test wasi_threads_exit_nonmain_wasi passed Test wasi_threads_exit_main_busy passed Test wasi_threads_exit_main_wasi passed Test wasi_threads_exit_nonmain_busy passed Test wasi_threads_spawn passed Test wasi_threads_exit_main_block passed Test wasi_threads_exit_nonmain_block passed ===== Test results ===== Runtime: toywasm v0.0 Suite: WASI threads proposal Total: 7 Passed: 7 Failed: 0 Test suites: 1 passed, 0 total Tests: 7 passed, 0 total spacetanuki% ```
Configuration menu - View commit details
-
Copy full SHA for 3d9d00d - Browse repository at this point
Copy the full SHA 3d9d00dView commit details -
Make wat test export memory as well
While it's a bit redundant to both import and export a memory, it's what WASI implementations expect. Emscripten, toywasm: Import alone is fine. But export wouldn't hurt. wasm-micro-runtime: Export is checked. Nothing actually seems to rely on it though. wasmtime: Export is necessary? References: https://github.com/WebAssembly/WASI/blob/main/legacy/application-abi.md#current-unstable-abi WebAssembly#22
Configuration menu - View commit details
-
Copy full SHA for cd61a73 - Browse repository at this point
Copy the full SHA cd61a73View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6206dd - Browse repository at this point
Copy the full SHA d6206ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f6a4fd - Browse repository at this point
Copy the full SHA 0f6a4fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b4f5b7 - Browse repository at this point
Copy the full SHA 3b4f5b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d12f784 - Browse repository at this point
Copy the full SHA d12f784View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43aaad2 - Browse repository at this point
Copy the full SHA 43aaad2View commit details -
wasi_threads_spawn.wat: sprinkle a few memory fences
While I suspect wait and notify are memory barriers for most implementations, it's safer to issue explicit fences.
Configuration menu - View commit details
-
Copy full SHA for 276bd47 - Browse repository at this point
Copy the full SHA 276bd47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7164d4b - Browse repository at this point
Copy the full SHA 7164d4bView commit details
Commits on Feb 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9082bca - Browse repository at this point
Copy the full SHA 9082bcaView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.