[WIP] wasm2c: group imports for a given module into a struct type. #1911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than given each import a magic name we can group imports into a
single struct and pass that struct into the init function.
This means that in the generated code all access to imported elements
now goes via the
g_imports
struct. Note that this is not a pointerbut a copy of the passed in struct, to avoid adding any extra
indirection.
This can be considered one step towards module instancing.
It also avoids the need for name mangling since individual imports no
longer live in the global namespace.