Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test largest valid initial size for memory32 in memory.wast #105

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Test largest valid initial size for memory32 in memory.wast #105

merged 2 commits into from
Nov 14, 2024

Conversation

evicy
Copy link
Contributor

@evicy evicy commented Nov 13, 2024

No description provided.

@evicy evicy mentioned this pull request Nov 13, 2024
Open
@sbc100
Copy link
Member

sbc100 commented Nov 13, 2024

Looks like the spec interpreter might need updating here? (The tests in failing in CI)

@bvisness bvisness mentioned this pull request Nov 13, 2024
Merged
sbc100
sbc100 reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess its not very important where this lands, but in theory this change could be make upstream in spec repo?

@bvisness
Copy link
Collaborator

Since all this should end up in the main spec repo before too long, I'm not concerned about it landing here first.

@bvisness bvisness merged commit 334f93f into WebAssembly:main Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evicy @sbc100 @bvisness