Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[interpreter] Fix crashes on try_table with parameters #321

Merged
merged 1 commit into from
Jul 4, 2024
Merged

[interpreter] Fix crashes on try_table with parameters #321

merged 1 commit into from
Jul 4, 2024

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Jul 4, 2024 •
edited
Loading

The test case was ported from toywasm.

@yamt
[interpreter] Fix crashes on try_table with parameters
4e80a93 
The test case was ported from toywasm.
@yamt yamt changed the title [interpreter] fix crashes on try_table with parameters [interpreter] Fix crashes on try_table with parameters Jul 4, 2024
rossberg
rossberg approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks!

This proposal could definitely use better test coverage.

@rossberg rossberg merged commit 5837755 into WebAssembly:main Jul 4, 2024
1 check passed
@yamt
Copy link
Contributor Author

yamt commented Jul 4, 2024

Oh, thanks!

This proposal could definitely use better test coverage.

maybe we can have a copy of block.wast with s/block/try_table/g as try_table w/o catch clauses is semantically identical to block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossberg rossberg rossberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yamt @rossberg