Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] Preview adding @since and @unstable gates to WASI 0.2 #604

Closed

Conversation

yoshuawuyts
Copy link
Member

In order to help create confidence in the implementation of @since and @feature in wasm-tools, this PR adds @since gates to the entirety of the WASI 0.2 API surface area. As well as bringing in the wit:clocks timezone surface area introduced in WebAssembly/wasi-clocks#61 under an @unstable attribute.

This PR is not intended to be merged, but to mainly to validate the implementation and to give an idea of what the resulting semantics of that will be in practice.

Validating the implementation

Using a local build of the wasm-tools branch, do:

for d in $(ls preview2);
   do wasm-tools component wit "./preview2/$d";
done;

This will warn wasm-tools not knowing where to find wasi:io, but it will not throw any errors about @since or @feature gates not parsing.

Next steps

Speaking concretely about the implementation: I'll split this PR up into several
sub-PRs on the correct sub-repositories. Those can't be merged until the
@since and @feature gate functionality is merged - but hopefully with this
draft PR we can get one step closer in building confidence that it will work out
as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant