Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【1.1.16】Empty pointer exception prompt when optimizing query task logs #298

Merged
merged 5 commits into from
Oct 7, 2023
Merged

【1.1.16】Empty pointer exception prompt when optimizing query task logs #298

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bbce1ae
update engine error msg
v-kkhuang Sep 21, 2023
d4ac5b5
update engine error msg
v-kkhuang Sep 21, 2023
bad60fc
update engine error msg
v-kkhuang Sep 21, 2023
cc68e03
formate code
v-kkhuang Oct 7, 2023
d22a35a
update msg
v-kkhuang Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...-application-manager/src/main/java/org/apache/linkis/manager/am/restful/EMRestfulApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,14 @@ public Message openEngineLog(HttpServletRequest req, @RequestBody JsonNode jsonN

private Message executeECMOperation(
EMNode ecmNode, String engineInstance, ECMOperateRequest ecmOperateRequest) {
if (Objects.isNull(ecmNode)) {
return Message.error(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use MessageFormat.format

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"ECM node :["
+ engineInstance
+ "] does not exist, Unable to open engine log(ECM节点:["
+ engineInstance
+ "] 异常，无法打开日志，可能是该节点服务重启或则服务异常导致)");
}
String operationName = OperateRequest$.MODULE$.getOperationName(ecmOperateRequest.parameters());
String userName = ecmOperateRequest.user();
if (ArrayUtils.contains(adminOperations, operationName) && Configuration.isNotAdmin(userName)) {
Expand Down