-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-layout): 支持配置 403、404 的 navigation #224
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,48 +1,35 @@ | ||
{ | ||
// Enable the ESlint flat config support | ||
"eslint.experimental.useFlatConfig": true, | ||
// Enable the ESlint flat config support | ||
"eslint.experimental.useFlatConfig": true, | ||
|
||
// Disable the default formatter, use eslint instead | ||
"prettier.enable": false, | ||
"editor.formatOnSave": false, | ||
// Disable the default formatter, use eslint instead | ||
"prettier.enable": false, | ||
"editor.formatOnSave": false, | ||
|
||
// Auto fix | ||
"editor.codeActionsOnSave": { | ||
"source.fixAll.eslint": "explicit", | ||
"source.organizeImports": "never" | ||
}, | ||
// Auto fix | ||
"editor.codeActionsOnSave": { | ||
"source.fixAll.eslint": "explicit", | ||
"source.organizeImports": "never" | ||
}, | ||
|
||
// Silent the stylistic rules in you IDE, but still auto fix them | ||
"eslint.rules.customizations": [ | ||
{ "rule": "style/*", "severity": "off" }, | ||
{ "rule": "*-indent", "severity": "off" }, | ||
{ "rule": "*-spacing", "severity": "off" }, | ||
{ "rule": "*-spaces", "severity": "off" }, | ||
{ "rule": "*-order", "severity": "off" }, | ||
{ "rule": "*-dangle", "severity": "off" }, | ||
{ "rule": "*-newline", "severity": "off" }, | ||
{ "rule": "*quotes", "severity": "off" }, | ||
{ "rule": "*semi", "severity": "off" } | ||
], | ||
// Enable eslint for all supported languages | ||
"eslint.validate": [ | ||
"javascript", | ||
"javascriptreact", | ||
"typescript", | ||
"typescriptreact", | ||
"vue", | ||
"html", | ||
"markdown", | ||
"json", | ||
"jsonc", | ||
"yaml" | ||
], | ||
|
||
// Enable eslint for all supported languages | ||
"eslint.validate": [ | ||
"javascript", | ||
"javascriptreact", | ||
"typescript", | ||
"typescriptreact", | ||
"vue", | ||
"html", | ||
"markdown", | ||
"json", | ||
"jsonc", | ||
"yaml" | ||
], | ||
|
||
"pair-diff.patterns": [ | ||
{ | ||
"source": "./fixtures/output/**/*.*", | ||
"target": "./fixtures/input/<base>" | ||
} | ||
] | ||
"pair-diff.patterns": [ | ||
{ | ||
"source": "./fixtures/output/**/*.*", | ||
"target": "./fixtures/input/<base>" | ||
} | ||
] | ||
} | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,19 +2,36 @@ | |
import antfu from '@antfu/eslint-config'; | ||
|
||
export default await antfu({ | ||
files: ['**/*.js', '**/*.jsx', '**/*.vue', '**/*.ts'], | ||
// TODO: 使用 ignore 代替 cli 命令中的配置 | ||
stylistic: { | ||
indent: 4, // 4, or 'tab' | ||
quotes: 'single', // or 'double' | ||
indent: 4, | ||
quotes: 'single', | ||
semi: 'always', | ||
}, | ||
typescript: true, | ||
vue: true, | ||
rules: { | ||
'curly': ['error', 'multi-line'], | ||
'vue/block-order': [ | ||
'error', | ||
{ | ||
order: ['template', 'script', 'style'], | ||
}, | ||
], | ||
'style/member-delimiter-style': [ | ||
'error', | ||
{ | ||
multiline: { | ||
delimiter: 'semi', | ||
requireLast: true, | ||
}, | ||
singleline: { | ||
delimiter: 'semi', | ||
requireLast: false, | ||
}, | ||
multilineDetection: 'brackets', | ||
}, | ||
], | ||
}, | ||
}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 这段代码是一个eslint配置文件的补丁。以下是对此代码的简要代码审查:
改进建议:
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,21 @@ | ||
{ | ||
"name": "fes.js", | ||
"type": "module", | ||
"version": "3.1.1", | ||
"private": true, | ||
"description": "一个好用的前端管理台快速开发框架", | ||
"preferGlobal": true, | ||
"private": true, | ||
"workspaces": [ | ||
"packages/*" | ||
], | ||
"type": "module", | ||
"license": "MIT", | ||
"keywords": [ | ||
"管理端", | ||
"fes", | ||
"fast", | ||
"easy", | ||
"strong" | ||
], | ||
"scripts": { | ||
"bootstrap": "pnpm i", | ||
"dev": "node scripts/build.mjs --watch", | ||
|
@@ -18,17 +26,10 @@ | |
"docs:build": "vitepress build docs", | ||
"docs:build-pages": "BASE=fes.js vitepress build docs", | ||
"test": "fes test", | ||
"lint": "eslint -c ./.eslintrc.js --ignore-pattern='templates' --ext .js,.jsx,.vue,.ts", | ||
"changelog": "conventional-changelog -p angular -i CHANGELOG.md -s" | ||
"lint": "eslint --ignore-pattern='templates'", | ||
"changelog": "conventional-changelog -p angular -i CHANGELOG.md -s", | ||
"hooks:sync": "simple-git-hooks" | ||
}, | ||
"license": "MIT", | ||
"keywords": [ | ||
"管理端", | ||
"fes", | ||
"fast", | ||
"easy", | ||
"strong" | ||
], | ||
"dependencies": { | ||
"chalk": "^5.0.1", | ||
"conventional-changelog-cli": "^4.1.0", | ||
|
@@ -38,14 +39,14 @@ | |
"semver": "^7.3.6" | ||
}, | ||
"devDependencies": { | ||
"@antfu/eslint-config": "^2.1.1", | ||
"@antfu/eslint-config": "^2.6.2", | ||
"@commitlint/cli": "^11.0.0", | ||
"@commitlint/config-conventional": "^11.0.0", | ||
"chokidar": "^3.5.3", | ||
"commitizen": "^4.3.0", | ||
"cz-conventional-changelog": "^3.3.0", | ||
"deepmerge": "^4.2.2", | ||
"eslint": "^8.54.0", | ||
"eslint": "^8.56.0", | ||
"fs-extra": "^11.1.1", | ||
"lint-staged": "^13.2.0", | ||
"simple-git-hooks": "^2.9.0", | ||
|
@@ -54,15 +55,15 @@ | |
"vue": "^3.3.4", | ||
"yargs-parser": "^21.1.1" | ||
}, | ||
"simple-git-hooks": { | ||
"pre-commit": "lint-staged", | ||
"commit-msg": "commitlint" | ||
}, | ||
"lint-staged": { | ||
"*.{js,jsx,vue,ts}": [ | ||
"npm run lint" | ||
] | ||
}, | ||
"simple-git-hooks": { | ||
"pre-commit": "lint-staged", | ||
"commit-msg": "commitlint -E HUSKY_GIT_PARAMS" | ||
}, | ||
"config": { | ||
"commitizen": { | ||
"path": "./node_modules/cz-conventional-changelog" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 此代码补丁主要包含以下更改:
可能的问题和改进建议:
请注意,由于限制,这里提供的是基于代码差异的高层分析。实际的代码质量评估应该是基于整个项目的上下文和需求进行的。 |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这段代码补丁主要是针对编辑器配置文件(可能是VS Code)进行的修改。以下是对代码进行的简要审查:
没有明显的错误或潜在风险。
改进建议:
请注意,以上只是一些改进建议,具体应该根据项目需求和团队规范进行调整。