Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSPP][SD.cpp] add CLI params #9

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[OSPP][SD.cpp] add CLI params #9

wants to merge 10 commits into from

Conversation

Tenderyi
Copy link

Added command line input and modified the constructor in the rust file.

@hydai
Copy link
Member

hydai commented Sep 13, 2024

Please fix the following two issues:

  1. Do the DCO sign your commit; see https://wasmedge.org/docs/zh-tw/contribute/#dco
  2. Please fix the conflicts in rust/src/lib.rs.

@Tenderyi Tenderyi closed this Sep 13, 2024
@Tenderyi
add CLI params
4f752ec 
Signed-off-by: Tenderyi <[email protected]>
@Tenderyi Tenderyi reopened this Sep 13, 2024
@hydai
Copy link
Member

hydai commented Sep 16, 2024

Please run rustfmt and clippy to fix the coding style.

hydai
hydai requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@hydai hydai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use #[allow(clippy::too_many_arguments)] to remove the too many arguments warnings.

rust/src/lib.rs Outdated Show resolved Hide resolved
example/src/main.rs Outdated Show resolved Hide resolved
@hydai hydai requested a review from apepkuss September 18, 2024 15:11
@hydai
Copy link
Member

hydai commented Sep 18, 2024

@apepkuss PTAL

@Tenderyi
fix the rust format4
4b6f439 
Signed-off-by: Tenderyi <[email protected]>
@Tenderyi Tenderyi requested a review from hydai September 22, 2024 16:30
apepkuss
apepkuss suggested changes Sep 23, 2024
View reviewed changes
rust/src/lib.rs Outdated Show resolved Hide resolved
rust/src/lib.rs Outdated Show resolved Hide resolved
@hydai
Copy link
Member

hydai commented Sep 25, 2024

This PR should be merged after WasmEdge/WasmEdge#3763 gets merged. There is a strong relationship between the plugin and this binding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apepkuss apepkuss apepkuss requested changes

@hydai hydai Awaiting requested review from hydai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tenderyi @hydai @apepkuss