Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo #237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix a typo #237

wants to merge 1 commit into from

Conversation

hiroshi
Copy link

@hiroshi hiroshi commented Jun 27, 2024

Explanation

Related issue

What type of PR is this

Proposed Changes

Copy link
Collaborator

alabulei1 commented Jun 27, 2024

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 4d994af7481c37297dc5f29db646c2b78cac8a36

Key changes:

  • The patch fixes a typo in the install.md file related to the word "the" that was missing before "version."

Potential problems:

  • The patch seems to be a straightforward fix for a typo, so there are no significant potential issues identified.
  • It's always good practice to ensure that changes like these do not introduce any new typos or formatting errors in the document.

Overall, this patch appears to be a simple correction of a typographical error and should not introduce any functional issues.

@hydai
Copy link
Member

hydai commented Jul 10, 2024

Hi @hiroshi
Please fix the DCO check, thanks.

@hiroshi
Copy link
Author

hiroshi commented Jul 10, 2024

It is very annoying to do git clone to local for just suggesting a typo in a document...

OK. I'll do it later. :-)

@hydai
Copy link
Member

hydai commented Jul 11, 2024

You can use the GitHub website and edit the committer message to append the DCO statement directly.

@hiroshi
Copy link
Author

hiroshi commented Jul 11, 2024

You can use the GitHub website and edit the committer message to append the DCO statement directly.

How do I do this?
https://stackoverflow.com/a/10728453

Do you mean that recreate another pull request online and don't forget to add Signed-off-by line?

I don't want to bother you, but I'm just wonder...

@hydai
Copy link
Member

hydai commented Jul 11, 2024

If you don't want to clone the repo, you can edit it with the signed-off-by line. Not sure if GitHub allows you to edit the existing commits from the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants