Merge pull request #2 from vm5/insights

Fix insights

.gitignore

@@ -1,3 +1,3 @@
 /.idea
 /vendor
-composer.lock
+composer.lock

.travis.yml

@@ -11,4 +11,4 @@ env:
   - SYMFONY_VERSION="3.4.*"
 
 install:
-   - composer require symfony/symfony:${SYMFONY_VERSION}
+   - composer require symfony/symfony:${SYMFONY_VERSION}

DependencyInjection/Configuration.php

@@ -18,11 +18,7 @@ class Configuration implements ConfigurationInterface
     public function getConfigTreeBuilder()
     {
         $treeBuilder = new TreeBuilder();
-        $rootNode = $treeBuilder->root('vm5_entity_translations');
-
-        // Here you should define the parameters that are allowed to
-        // configure your bundle. See the documentation linked above for
-        // more information on that topic.
+        $treeBuilder->root('vm5_entity_translations');
 
         return $treeBuilder;
     }

DependencyInjection/VM5EntityTranslationsExtension.php

@@ -2,10 +2,10 @@
 
 namespace VM5\EntityTranslationsBundle\DependencyInjection;
 
-use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\Config\FileLocator;
-use Symfony\Component\HttpKernel\DependencyInjection\Extension;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Loader;
+use Symfony\Component\HttpKernel\DependencyInjection\Extension;
 
 /**
  * This is the class that loads and manages your bundle configuration.
@@ -19,9 +19,6 @@ class VM5EntityTranslationsExtension extends Extension
      */
     public function load(array $configs, ContainerBuilder $container)
     {
-        $configuration = new Configuration();
-        $config = $this->processConfiguration($configuration, $configs);
-
         $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
         $loader->load('services.xml');
     }

EventSubscriber/LocaleListener.php

@@ -40,4 +40,4 @@ public function onKernelRequest(GetResponseEvent $event)
     {
         $this->guessLoader->load();
     }
-}
+}

Form/EventListener/ResizeFormListener.php

@@ -8,7 +8,6 @@
 use Symfony\Component\Form\FormInterface;
 use VM5\EntityTranslationsBundle\Model\EditableTranslation;
 use VM5\EntityTranslationsBundle\Model\Language;
-use VM5\EntityTranslationsBundle\Model\Translatable;
 use VM5\EntityTranslationsBundle\Model\Translation;
 
 class ResizeFormListener implements EventSubscriberInterface
@@ -154,9 +153,6 @@ public function submit(FormEvent $event)
         /** @var EditableTranslation[] $translations */
         $translations = $event->getData();
 
-        /** @var Translatable $translatable */
-        $translatable = $event->getForm()->getParent()->getData();
-
         $forDelete = [];
         foreach ($this->languages as $language) {
             $translation = $translations[$language->getLocale()];

Form/Type/TranslationsType.php

@@ -75,4 +75,4 @@ public function configureOptions(OptionsResolver $resolver)
 
         $resolver->setDefaults($options);
     }
-}
+}

Guesser/Guesser.php

@@ -14,4 +14,4 @@ public function guessLocale();
      * @return string[]|null
      */
     public function guessFallbackLocales();
-}
+}

Guesser/GuesserLoader.php

@@ -46,4 +46,4 @@ public function load()
             }
         }
     }
-}
+}

Guesser/SymfonyTranslationGuesser.php

@@ -34,4 +34,4 @@ public function guessFallbackLocales()
 
         return null;
     }
-}
+}

Model/EditableTranslation.php

@@ -10,4 +10,4 @@ interface EditableTranslation extends Translation
      * @return void
      */
     public function setLanguage(Language $language);
-}
+}

Model/Language.php

@@ -8,4 +8,4 @@ interface Language
      * @return string
      */
     public function getLocale();
-}
+}

Resources/views/bootstrap_3_tab_layout.html.twig

@@ -44,4 +44,4 @@
         {{ form_widget(child) }}
         {{ form_errors(child) }}
     </div>
-{% endblock %}
+{% endblock %}

Translator.php

@@ -194,4 +194,4 @@ private function getId(Translatable $translatable)
     {
         return spl_object_hash($translatable);
     }
-}
+}

Twig/Extension/TranslationExtension.php

@@ -52,4 +52,4 @@ public function translate(Translatable $translatable, $field, $locale = null)
     {
         return $this->translator->translate($translatable, $field, $locale);
     }
-}
+}

composer.json

@@ -1,34 +1,35 @@
 {
-  "name": "vm5/entity-translations-bundle",
-  "description": "This bundle provides translations for entities in your project. It's a bundle, but can be used standalone.",
-  "type": "symfony-bundle",
-  "authors": [
-    {
-      "name": "Bozhidar Hristov",
-      "email": "[email protected]"
+    "name": "vm5/entity-translations-bundle",
+    "license": "MIT",
+    "description": "This bundle provides translations for entities in your project. It's a bundle, but can be used standalone.",
+    "type": "symfony-bundle",
+    "authors": [
+        {
+            "name": "Bozhidar Hristov",
+            "email": "[email protected]"
+        }
+    ],
+    "keywords": [
+        "translation"
+    ],
+    "require-dev": {
+        "phpunit/phpunit": "^5.7",
+        "symfony/symfony": "~2.8 | ~3.0",
+        "doctrine/orm": "~2.5.0",
+        "doctrine/doctrine-bundle": "~1.8"
+    },
+    "suggest": {
+        "doctrine/orm": "Autoload translations with Doctrine ORM",
+        "symfony/symfony": "Needed for easy integration into Symfony",
+        "twig/twig": "Needed to use Twig Extension to translate in twig.",
+        "symfony/property-access": "Needed for Twig extension to translate",
+        "symfony/translation": "Needed if you want to use Symfony Translation's configuration. Otherwise this bundle should be setup separately.",
+        "symfony/form": "Needed if you want to use forms to translate entities.",
+        "doctrine/doctrine-bundle": "Needed if you want to use forms to translate entities."
+    },
+    "autoload": {
+        "psr-4": {
+            "VM5\\EntityTranslationsBundle\\": ""
+        }
     }
-  ],
-  "keywords": [
-    "translation"
-  ],
-  "require-dev": {
-    "phpunit/phpunit": "^5.7",
-    "symfony/symfony": "~2.8 | ~3.0",
-    "doctrine/orm": "~2.5.0",
-    "doctrine/doctrine-bundle": "~1.8"
-  },
-  "suggest": {
-    "doctrine/orm": "Autoload translations with Doctrine ORM",
-    "symfony/symfony": "Needed for easy integration into Symfony",
-    "twig/twig": "Needed to use Twig Extension to translate in twig.",
-    "symfony/property-access": "Needed for Twig extension to translate",
-    "symfony/translation": "Needed if you want to use Symfony Translation's configuration. Otherwise this bundle should be setup separately.",
-    "symfony/form": "Needed if you want to use forms to translate entities.",
-    "doctrine/doctrine-bundle": "Needed if you want to use forms to translate entities."
-  },
-  "autoload": {
-    "psr-4": {
-      "VM5\\EntityTranslationsBundle\\": ""
-    }
-  }
-}
+}

phpunit.xml.dist

@@ -31,4 +31,4 @@
             </exclude>
         </whitelist>
     </filter>
-</phpunit>
+</phpunit>